-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Expand WordPress Intelligence support to other locales #25034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
b4a20c9 to
7bcbb5b
Compare
| case .intelligence: | ||
| let languageCode = Locale.current.language.languageCode?.identifier | ||
| return (languageCode ?? "en").hasPrefix("en") | ||
| guard #available(iOS 26, *) else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's technically redundant; just some more defensive code.
|
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30006 | |
| Version | PR #25034 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 7bcbb5b | |
| Installation URL | 741op7a4ptam8 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30006 | |
| Version | PR #25034 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 7bcbb5b | |
| Installation URL | 5k7hgqrctv170 |
| with fewer than 10 words. | ||
| The summary should be clear, informative, and written in a neutral tone. | ||
| You MUST generate the summary in the same language as the support request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I think the prompt can be more direct here: "You MUST generate the summary in the (locale.identifier) locale.", and remove the makeLocaleInstructions() above?
|
I'd expect the generated summary to be in the post's language, rather than the device's language. What do you think? |
|
Oh, sorry, I missed that there are updates to other prompts too. |
|
The post summary generation is not updated in this PR. Probably because that went to a separate code path: |
|
I used a news article in Chinese for testing. The post tags generation in the "Post Settings" page does not work for me. Here are some debug prints: |





Fixes CMM-762: Excerpts are created in the system language not the content language and CMM-798: Add support for other locales
I smoke-tested it by generating a post in Spanish and testing that the excerpts are also in Spanish. It should work for any other scenarios as well. If there are any issues, I suggest addressing them forward.